Regression: cannot connect Fedora / OpenID account (NPE), various changes not saved

Description

1. Log in
2. Go to dashboard Settings
3. Click the Fedora or Yahoo button in Connected Accounts

16:27:06,386 ERROR [org.zanata.exception.handler.AbstractExceptionHandler] (default task-6) exception happened in view: /dashboard/home.xhtml: java.lang.NullPointerException at org.zanata.security.ZanataOpenId.getOpenIdProvider(ZanataOpenId.java:350) at org.zanata.security.ZanataOpenId$Proxy$_$$_WeldSubclass.getOpenIdProvider(Unknown Source)

Occurs for both connecting and merging accounts.

Environment

None

Activity

Show:

Sean Flanigan 30 June 2016 at 07:59

Never mind, I see that you already put in https://zanata.atlassian.net/browse/ZNTA-1215#icft=ZNTA-1215 for the merge bug.

Sean Flanigan 30 June 2016 at 07:39

Could I get you to document the steps to reproduce the problem you reported, where merging accounts had to be requested twice, please?

Sean Flanigan 27 June 2016 at 00:59

The fix for this has exposed wider problems (in various services) with transactions not being committed, ie messages like "your changes have been saved" but in fact the changes get rolled back. These problems are also addressed by this pull request.

Sean Flanigan 17 June 2016 at 08:27

TODO: check that merged accounts, added credentials are listed in the Account Settings page. Are changes being saved? (Might need @Transactional).

Sean Flanigan 15 June 2016 at 07:46

It looks like ZanataOpenId.getOpenIdProvider() is producing a bean, which is only used in the same class ZanataOpenIdWarning. And that method is trying to use a bean (ZanataCredentials credentials) which needs to be injected.

Perhaps this is exposing a difference in the injection model used by CDI and Seam 2.


What do you think?

Ready for Release

Details

Assignee

Reporter

Labels

Tested Version/s

Sprint

Fix versions

Affects versions

Priority

More fields

Created 15 June 2016 at 06:33
Updated 27 June 2018 at 02:21
Resolved 29 June 2016 at 02:56

Flag notifications