Regression: cannot connect Fedora / OpenID account (NPE), various changes not saved

Description

1. Log in
2. Go to dashboard Settings
3. Click the Fedora or Yahoo button in Connected Accounts

Occurs for both connecting and merging accounts.

Environment

None

Activity

Show:
Sean Flanigan
June 15, 2016, 7:46 AM

It looks like ZanataOpenId.getOpenIdProvider() is producing a bean, which is only used in the same class ZanataOpenId. And that method is trying to use a bean (ZanataCredentials credentials) which needs to be injected.

Perhaps this is exposing a difference in the injection model used by CDI and Seam 2.


What do you think?

Sean Flanigan
June 17, 2016, 8:27 AM

TODO: check that merged accounts, added credentials are listed in the Account Settings page. Are changes being saved? (Might need @Transactional).

Sean Flanigan
June 27, 2016, 12:59 AM

The fix for this has exposed wider problems (in various services) with transactions not being committed, ie messages like "your changes have been saved" but in fact the changes get rolled back. These problems are also addressed by this pull request.

Sean Flanigan
June 30, 2016, 7:39 AM

Could I get you to document the steps to reproduce the problem you reported, where merging accounts had to be requested twice, please?

Sean Flanigan
June 30, 2016, 7:59 AM

Never mind, I see that you already put in for the merge bug.

Assignee

Sean Flanigan

Reporter

Damian Jansen

Tested Version/s

None

Sprint

None

Fix versions

Affects versions

Priority

High
Configure