Regression: cannot connect Fedora / OpenID account (NPE), various changes not saved

It looks like ZanataOpenId.getOpenIdProvider() is producing a bean, which is only used in the same class ZanataOpenId. And that method is trying to use a bean (ZanataCredentials credentials) which needs to be injected.

Perhaps this is exposing a difference in the injection model used by CDI and Seam 2.

What do you think?

TODO: check that merged accounts, added credentials are listed in the Account Settings page. Are changes being saved? (Might need @Transactional).

The fix for this has exposed wider problems (in various services) with transactions not being committed, ie messages like "your changes have been saved" but in fact the changes get rolled back. These problems are also addressed by this pull request.

Could I get you to document the steps to reproduce the problem you reported, where merging accounts had to be requested twice, please?

Never mind, I see that you already put in for the merge bug.