Use the same dependency versions in frontend and zanata-editor

Description

  • all dependencies that are common to both modules should specify the same version in package.json of both modules

  • all dependencies must specify an exact version (no prefix with ^ or ~)

  • version updates can be in either module, or both

  • frontend and zanata-editor must both build and run properly after this change

Activity

Show:
Damian Jansen
July 18, 2016, 5:29 AM

Requires some evidence of fix, to test.

David Mason
July 19, 2016, 2:33 AM

What kind of evidence do you want? The first 3 points in the description are just about what is in zanata-server/frontend/src/main/web/package.json and zanata-server/zanata-editor/src/package.json and the last point is to make sure nothing was messed up.

Damian Jansen
July 19, 2016, 6:43 AM

was there a code change somewhere? I'm not sure I understand the change that was made.

David Mason
July 19, 2016, 7:08 AM

Changes were mainly to dependencies, but there are also code style refactors. All the changes:

  • Updated versions of some npm dependencies in zanata-editor and frontend.

    • Updated shrinkwrap for zanata-editor and frontend to include the dev dependencies - we were missing locking down versions on a whole bunch of build tools

  • Refactored some code to pass some updated linting rules that came with the new dependencies in zanata-editor.

  • Fixed up the tests in frontend so that `npm test` will now actually run some tests.

David Mason
July 20, 2016, 6:44 AM

this is ready to test, let me know if you need more info to test it.

Ready for Release

Assignee

Damian Jansen

Reporter

David Mason

Labels

None

Tested Version/s

None

Story Points

2

Epic Link

Sprint

None

Fix versions

Priority

unspecified
Configure