Javascript alert failed functional test

Description

Zanata functional test is having problem handling javascript `alert` or `confirm`.
As fix right now, we are disabling failed tests.

Task:

  • replace javascript `alert` or `confirm` with modal UI.

  • maybe prevent `alert` or `confirm` from being use in zanata-server

Identified page:
tm/index.xhtml
admin/rolemanager.xhtml
admin/rolerules.xhtml
admin/usermanager.xhtml
iteration/view.xhtml
language/home.xhtml
project/home.xhtml
project/project.xhtml
version-copy-action-loader.xhtml
dashboard/settings.xhtml
project/versions-tab.xhtml
version/documents-tab.xhtml
version/languages-tab.xhtml
version/settings-tab.xhtml

Environment

None

Activity

Show:
Alex Eng
July 26, 2016, 1:09 AM

Current issue:
https://bugs.chromium.org/p/chromedriver/issues/detail?id=1169

Same issue in previous version:
https://groups.google.com/forum/#!topic/webdriver/pxDaaxX6a58

Sean Flanigan
July 26, 2016, 1:06 AM

Could you please add a link here to the chromedriver bug report?

Sean Flanigan
July 26, 2016, 12:50 AM

We can use a checkstyle regexp rule to keep alert from creeping back in anywhere (including JSF): http://checkstyle.sourceforge.net/config_regexp.html

From what I can tell, we don't have any other references to "alert(" in JSF, apart from tm/home.xhtml. We've got about half a dozen in libs.js.map, ie part of the new editor.

Alex Eng
July 26, 2016, 12:31 AM

Pull request for disabling failed tests:
https://github.com/zanata/zanata-server/pull/1253

Ready for Release

Assignee

Alex Eng

Reporter

Alex Eng

Labels

None

Tested Version/s

None

Time tracking

0m

Time remaining

0m

Sprint

None

Fix versions

Priority

unspecified