Update shrinkwrap to make the deployment easier

Description

Right now we are getting all dep from pom as well as from maven reactor. This causes duplication (e.g. zanata-model will be in both places and the one from pom will not be the most up-to-date version). Therefore we have to add explicit rejection for those ones that are in reactor (e.g. zanata-model etc). This is tedious and error prone. There might be a better way to do it.

Activity

Show:
Sean Flanigan
November 2, 2016, 4:54 AM

I would argue this is a bug in our test setup, since they don't test the correct version of zanata-model, zanata-common-api, etc.

Patrick Huang
November 2, 2016, 5:36 AM

We are not even testing jsf or gwt or frontend code in arquillian and yet we pull in all of these jars and classes. Maybe we should also shrink the size of that test war?

Sean Flanigan
November 2, 2016, 5:43 AM

Perhaps, but the more we exclude from the Arquillian deployment, the more danger we will change the behaviour of CDI (eg ambiguous Producers), and end up having to rely on functional tests just to see if the zanata war file still deploys.

That sort of code should just be sitting there, doing almost nothing in arquillian tests. Is it breaking something?

Sean Flanigan
November 2, 2016, 8:01 AM

Could you take a look at the pull request please?

Ready for Release

Assignee

Sean Flanigan

Reporter

Patrick Huang

Labels

Tested Version/s

None

Sprint

None

Fix versions

Priority

unspecified
Configure