Details

    • Type: Sub-task
    • Status: Merged (View workflow)
    • Priority: High
    • Resolution: Ready for Release
    • Affects Version/s: None
    • Fix Version/s: platform-4.1.0
    • Component/s: UI
    • Labels:
      None
    • Tested Version/s:
      None
    • Sprint:
      17.02, 17.03

      Description

      References to zanata-ui and atomic css have not been removed from package/webpack files in ZNTA-1606 Merged - my attempts to do this just gave me build errors.

      ZNTA-1606 Merged just covers the complete removal of atomic css classes from containers, components and templates in frontend, but not from the builds itself. *References to atomic/zanata-ui will need to be removed from the build scripts before merging into master*

      This is what I tried to do:

      1. Removed zanata-ui successfully using yarn remove... in frontend
      2. Removed line in webpack: path.join(__dirname, 'node_modules/zanata-ui/dist')
      3. Build.

      I got the following error:

      modulesModuleParseError: Module parse failed: /Users/kathryngough/node_modules/zanata-ui/dist/zanata-ui.css Unexpected character '@' (1:0)
      [ERROR] You may need an appropriate loader to handle this file type.
      [ERROR] SyntaxError: Unexpected character '@' (1:0)
      [ERROR] at Parser.pp$4.raise (/Users/kathryngough/IdeaProjects/zanata-platform/server/zanata-frontend/src/frontend/node_modules/acorn/dist/acorn.js:2221:15)......

      I am unable to put ZNTA-1606 Merged on review until this has been resolved. That is, frontend builds and runs successfully without any reference to either ui or atomic.

        Attachments

          Issue links

            Activity

              People

              • Assignee:
                aeng Alex Eng
                Reporter:
                kathryngo Kathryn Gough
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: