Uploaded image for project: 'Zanata'
  1. ZNTA-2197

Unmaintained Hibernate Search config for some entities

    Details

    • Type: Task
    • Status: Merged (View workflow)
    • Priority: unspecified
    • Resolution: Ready for Release
    • Affects Version/s: None
    • Fix Version/s: platform-4.4.0
    • Component/s: None
    • Labels:
    • Tested Version/s:
      None
    • Sprint:
      17.20

      Description

      We currently have the Hibernate Search annotation @Indexed on these classes:

      HAccount - queried by nothing that I can find - commented out in AccountDAO (update: removed by https://github.com/zanata/zanata-platform/pull/504)
      HGlossaryEntry - queried by nothing that I can find (update: removed by https://github.com/zanata/zanata-platform/pull/576)
      HGlossaryTerm - queried by GlossaryDAO
      HProject - queried by ProjectDAO
      HProjectIteration - queried by nothing that I can find (update: removed by https://github.com/zanata/zanata-platform/pull/576)
      HTextFlowTarget - queried by TranslationMemoryServiceImpl
      TransMemoryUnit - queried by TranslationMemoryServiceImpl

      If we're not planning to use (or maintain) the Lucene-related code in these classes, we should remove all their Hibernate Search annotations. Leaving them half-supported makes the code harder to understand (eg why is this entity @Indexed but it doesn't handle disabled records?), wasting development time, and also causes unnecessary indexing at runtime.

      See also https://github.com/zanata/zanata-platform/pull/504

        Attachments

          Activity

            People

            • Assignee:
              aeng Alex Eng
              Reporter:
              sflanigan Sean Flanigan
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: