Fix AssertJ assertion names

Description

We have a lot of AssertJ assertions to which we have attempted to give readable names, but we actually have the method calls in the wrong order.

The .as(description) call must appear before the actual assertion check, like this:

not like this:

(IntelliJ actually marks the as call as suspicious, because its result is never used.)

This regex search via ripgrep should show the vast majority of them (with very few false positives):

After those are cleaned up, it might be worth glancing at the results for this too (in case some of the descriptions include parens):

Status

Assignee

Damian Jansen

Reporter

Sean Flanigan

Labels

None

Tested Version/s

None

Fix versions

Priority

unspecified
Configure