Uploaded image for project: 'Zanata'
  1. ZNTA-2610

Ant Design (antd) requires React 16, but we only have React 15

    Details

    • Type: Bug
    • Status: Merged (View workflow)
    • Priority: unspecified
    • Resolution: Ready for Release
    • Affects Version/s: None
    • Fix Version/s: platform-4.6.0
    • Component/s: None
    • Labels:
    • Tested Version/s:
      None
    • Sprint:
      18.11, 18.12, 18.13

      Description

      This yarn warning indicates some potentially serious technical debt:

      [ERROR] warning " > antd@3.4.0" has incorrect peer dependency "react@>=16.0.0". [ERROR] warning " > antd@3.4.0" has incorrect peer dependency "react-dom@>=16.0.0". [ERROR] warning "antd > rc-editor-mention@1.1.6" has unmet peer dependency "immutable@^3.7.4".
      

      (from https://github.com/zanata/zanata-platform/pull/773)

      This means that any antd components which actually require React 16 changes will not work until we upgrade React. In fact, any antd upgrade could potentially lead to existing, currently working components breaking if the new version makes more use of React 16 (especially lifecycle changes).

        Attachments

          Issue links

            Activity

              People

              • Assignee:
                efloden Earl Mark Floden
                Reporter:
                sflanigan Sean Flanigan
              • Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: