Reverse the compare order for TM diffs, remove strikeout

Description

User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:18.0) Gecko/20100101 Firefox/18.0
Build Identifier:

Whenever a particular string is selected for translation at the editor, the corresponding translation memory suggestions that are displayed on the TM window always shows the entry that is to be inserted to make it a 100% match for the target string as "strike out" and red in colour and the entry to be removed in blue colour. To elaborate, if a TM suggestion is giving 96% match and requires only a single word to be removed and a new word to be inserted in it's place to make it a 100% match, the word to be inserted is shown as "strike out" and red in colour and the word to be removed is shown in blue colour whereas it should have been the other way around, i.e, "strike out" and red for the entry to be removed and blue for the one to be inserted to make it a 100% match. I will attach a screenshot after this bug is filed so that the issue can be understood better.

Zanata version: 2.0.3

Reproducible: Always

Steps to Reproduce:
1. Login into Zanata
2. Open a project and go to the editor.
3. Select a string a look for TM suggestions which are less than 100% match.
4. Look for the entries that need to be inserted or removed to make a 100% match.
Actual Results:
The entry to be inserted is shown as "strike out" and red in colour and the entry to be removed is shown in blue colour.

Expected Results:
The entry to be inserted should be shown in blue and the entry to be removed as "strike out" and red in colour.

This issue has been there in earlier versions too. I have provided the version as 2.0 owing to the current version that I am using which is 2.0.3. If the version number needs to be changed for this bug, kindly do the same.

Environment

None

Activity

Show:
Kathryn Gough
September 16, 2016, 4:30 AM

just had to get my head around what tm match and search text actually were. sorry for all the questions

Sean Flanigan
September 21, 2016, 7:28 AM

I see that you marked the issue as QA, but unfortunately we don't yet have any automation to add the "On QA" label to the pull request in github. You'll still need to do that, at least until we can convince to watch for issues marked QA

David Mason
September 28, 2016, 12:35 AM

Defects found in demo

  • Legend does not update depending on highlight/diff

  • Legend colours are wrong (description is opposite of reality)

  • Legend descriptions need grammar correction (s/contain/contains/)

  • Inline legend and popup legend need to be checked for consistency

  • Info button should probably be with the inline legend, rather than next to source

  • Highlight mode does not display properly. Technical note: class CodeMirror-searching is missing from stylesheet

Action item

Define an example search and several example matches, manually define exactly how we expect them to highlight, then use that to check that the implementation is correct.

Kathryn Gough
September 29, 2016, 12:33 AM

Cheers , I had these issues explained to me in detail this morning. Shall fix them soon

Kathryn Gough
September 30, 2016, 12:12 AM
Edited

Legend does not update depending on highlight/diff
Legend colours are wrong (description is opposite of reality)
Legend descriptions need grammar correction (s/contain/contains/)
Inline legend and popup legend need to be checked for consistency
Info button should probably be with the inline legend, rather than next to source
Highlight mode does not display properly. Technical note: class CodeMirror-searching is missing from stylesheet

Ready for Release

Assignee

Alex Eng

Reporter

Nilamdyuti Goswami

Labels

Tested Version/s

None

Story Points

2

Components

Sprint

None

Fix versions

Priority

unspecified
Configure