Project-wide search and replace only shows 15 results per document

Description

It has a hard-coded page size at org/zanata/webtrans/client/ui/SearchResultsDocumentTable.java:112

But we didn't provide a pager.

Environment

None

Activity

Show:
Carlos Munoz
August 5, 2015, 4:34 AM

What to implement:

Enable a client-side pager for all results in a document.
Change label on "Select All" to "Select All visible rows" and make sure that it behaves accordingly. (Checkboxes per document and the one at the top of the table)

Patrick Huang
August 27, 2015, 1:14 AM
Edited

When we estimate and discuss about this bug, we were assuming the "Select All" checkbox will not work on other pages. But I just find out that it actually work on all rows (visible or not). So the "Select All" label is in fact selecting all. Do we want to leave it as is?

Damian Jansen
August 27, 2015, 1:22 AM

I think Select All should be select "all instances of" and perhaps a second mechanism to select all on the page. (i.e. leave as-is?)

Carlos Munoz
August 27, 2015, 1:31 AM

I'd say so too (leave as is). Lets make it clear in the documentation though.

Sean Flanigan
August 27, 2015, 1:54 AM

We should make it clear on the page too (both at the document Select All and at the top level Select All), not just in the docs.

Note that GMail (which many people will have experience of) first selects all on the page, then adds the option of selecting all on any page. It doesn't select the non-visible rows unless you ask it to explicitly.

Ready for Release

Assignee

Damian Jansen

Reporter

Patrick Huang

Labels

Tested Version/s

None

Story Points

2

Sprint

None

Fix versions

Affects versions

Priority

unspecified
Configure