Error message shown at top of TM Version Merge dialog

Description

Any errors for the TM Version Merge dialog will be displayed at the top. Typically the user will have had to scroll the dialog down to use it, so it appears to the user that nothing has happened if an error occurs.

Produced the error by attempting to run two merges at the same time.

See screenshots

Environment

None

Attachments

4
  • 03 Aug 2017, 04:16 am
  • 26 Jul 2017, 12:25 am
  • 25 Jul 2017, 04:14 am
  • 25 Jul 2017, 04:14 am

Activity

Show:

Former user 2 August 2018 at 01:25

Using Ant Design notifications

Former user 3 August 2017 at 09:07

Great work . I am looking at this now. I have noticed that in Chrome on macOS that the background-color is being overridden by some zanata-assets css that I migrated in recently, making the background white.

For the meantime I have applied !important tags to the alert background css until I get the chance to tidy up the assets and frontend css. I really do not like using these !important things, but with all the conflicting code that still remains, sometimes it is necessary so I don't break other elements.

I will push my change to the branch and review for you also.

Former user 2 August 2017 at 07:09

Thanks . I am considering toast notifications in the future for things like this.

Former user 2 August 2017 at 07:03

Hi
I've opened a branch for this: efloden/modal-notification/ZNTA-2136
Will see if I can get that alert component working with a fixed position now

Former user 2 August 2017 at 06:57
Edited

Hey

If you run make storybook-frontend and check out the Alert - error story, you will see a component you can use.

Custom css to apply position: fixed; to the alert will make sure it appears at the top of the modal even when scrolling.

Happy to get this done for you if you have other priorities.

Not Applicable

Details

Assignee

Reporter

Labels

Tested Version/s

Components

Affects versions

Priority

More fields

Created 25 July 2017 at 04:14
Updated 2 August 2018 at 01:25
Resolved 2 August 2018 at 01:25

Flag notifications