Turn on SUITCSS css linting for frontend
Description
blocks
relates to
Activity
Show:
Former user 5 October 2017 at 06:36
Created a new issue @Former user https://zanata.atlassian.net/browse/ZNTA-2231
Former user 5 October 2017 at 06:34
Shall look into it
Former user 5 October 2017 at 05:24
Is there a JIRA to enable some kind of linter? There are some checks that are universal (duplicate properties, etc.) so we should at least have something checking the basics.
Former user 5 October 2017 at 01:10
Because we use so many bootstrap based classes this postcss suit linter should not be used. We will never be able to get it to a point where there are 0 warnings. Also, this linter does not do anything but check that the classnames follow a certain naming convention, which we do not follow consistently throughout frontend and editor (including gwt) due to GWT styling and the react-bootstrap components.
postcss-bem-linter is commented out in the frontend webpack config. It generates a lot of warnings when it is turned on. We should turn it on and fix the warnings, then leave it on.
We can do this incrementally by turning on the linter in a local branch, fixing some warnings, then pushing the fixes without pushing the linter activation.
Technical contact: @Former user (has configured this, just left it turned off until warnings can be fixed)