Attribution check happens post translate, allowing unattributed translations

Description

Performing a MT translation on a (eg.) JSON document allows the document to be translated, but as the attribution is hard-coded to a subset (.po, .properties) and done afterwards, the translations are left as is without attribution.

(ERROR [org.zanata.async.AsyncTaskManager] (pool-11-thread-3) Exception when executing an asynchronous task.: java.lang.RuntimeException: unexpected DocumentType for HDocument(docId=flatten/slash-in-key.json, name=slash-in-key.json, path=flatten/, revision=1, locale=HLocale(localeId=en-US)) at org.zanata.service.impl.AttributionService.addAttribution(AttributionService.kt:76))

The check should happen before sending the document to MT.

Environment

None

Activity

Show:

Former user 18 July 2018 at 23:55

Turns out it was just a missing "continue;"

Ready for Release

Details

Assignee

Reporter

Labels

Tested Version/s

Components

Fix versions

Affects versions

Priority

More fields

Created 18 July 2018 at 13:56
Updated 25 July 2018 at 00:52
Resolved 19 July 2018 at 06:39

Flag notifications